Please identify two types of antipatterns (also called code smells) in the following source code: public abstract class AbstractCollection implements Collection { public void addAll (AbstractCollection c) { if (c instanceof Set) { Set s = (Set) c; for (int i=0; i < s.size () ; i ++) { if (!contains (s.getElementAt (i) )) { add (s.getElementAt(i) ); } } } else if (c instanceof List) { List l = (List) c; for ( int i=0; i < l.size() ; i++) { if ( !contains l.get (i) )) { add (l.get(i) ); } } } else if ( c instanceof Map) { Map m = (Map) c; for (int i=0; i

Database System Concepts
7th Edition
ISBN:9780078022159
Author:Abraham Silberschatz Professor, Henry F. Korth, S. Sudarshan
Publisher:Abraham Silberschatz Professor, Henry F. Korth, S. Sudarshan
Chapter1: Introduction
Section: Chapter Questions
Problem 1PE
icon
Related questions
Question

Please identify two types of antipatterns (also called code smells) in the following source code:

public abstract class AbstractCollection implements Collection {
public void addAll (AbstractCollection c) {
if (c instanceof Set) {
Set s = (Set) c;
for (int i=0; i < s.size () ; i ++) {
if (!contains (s.getElementAt (i) )) {
add (s.getElementAt(i) );
}
}
} else if (c instanceof List) {
List l = (List) c;
for ( int i=0; i < l.size() ; i++) {
if ( !contains l.get (i) )) {
add (l.get(i) );
}
}
} else if ( c instanceof Map) {
Map m = (Map) c;
for (int i=0; i<m.size () ; i++)
add (m.key[i] , m.values [i] );
}
}

Expert Solution
steps

Step by step

Solved in 2 steps with 1 images

Blurred answer
Knowledge Booster
Developing computer interface
Learn more about
Need a deep-dive on the concept behind this application? Look no further. Learn more about this topic, computer-science and related others by exploring similar questions and additional content below.
Similar questions
  • SEE MORE QUESTIONS
Recommended textbooks for you
Database System Concepts
Database System Concepts
Computer Science
ISBN:
9780078022159
Author:
Abraham Silberschatz Professor, Henry F. Korth, S. Sudarshan
Publisher:
McGraw-Hill Education
Starting Out with Python (4th Edition)
Starting Out with Python (4th Edition)
Computer Science
ISBN:
9780134444321
Author:
Tony Gaddis
Publisher:
PEARSON
Digital Fundamentals (11th Edition)
Digital Fundamentals (11th Edition)
Computer Science
ISBN:
9780132737968
Author:
Thomas L. Floyd
Publisher:
PEARSON
C How to Program (8th Edition)
C How to Program (8th Edition)
Computer Science
ISBN:
9780133976892
Author:
Paul J. Deitel, Harvey Deitel
Publisher:
PEARSON
Database Systems: Design, Implementation, & Manag…
Database Systems: Design, Implementation, & Manag…
Computer Science
ISBN:
9781337627900
Author:
Carlos Coronel, Steven Morris
Publisher:
Cengage Learning
Programmable Logic Controllers
Programmable Logic Controllers
Computer Science
ISBN:
9780073373843
Author:
Frank D. Petruzella
Publisher:
McGraw-Hill Education